Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create library runtime jar #1510

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Create library runtime jar #1510

merged 1 commit into from
Jun 29, 2023

Conversation

piotrszul
Copy link
Collaborator

Resolves #1443

@piotrszul
Moved creation of shaded jar to library-runtime module as main its …
9f14742 
…main artefact.

Added relocation of `caffeine` in the uber jar.
Simplified dependencies of `utilities` by removing unnecessary `curator-client`.
@codecov
Copy link

codecov bot commented Jun 29, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (bd557ef) 85.51% compared to head (9f14742) 85.51%.

Additional details and impacted files 
@@            Coverage Diff             @@
##               main    #1510    +/-   ##
==========================================
  Coverage     85.51%   85.51%            
==========================================
  Files           339      339            
  Lines          7806     7806            
  Branches        519      519            
==========================================
  Hits           6675     6675            
  Misses          841      841            
  Partials        290      290
Impacted Files Coverage Δ
lib/python/pathling/etc.py 94.44% <100.00%> (ø)
...java/au/csiro/pathling/utilities/ObjectHolder.java 76.19% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@piotrszul piotrszul self-assigned this Jun 29, 2023
@piotrszul piotrszul added this to the v6.2.3 milestone Jun 29, 2023
@johngrimes johngrimes changed the base branch from main to release/6.2.3 June 29, 2023 06:43
johngrimes
johngrimes approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@johngrimes johngrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's merge to the release branch then test Maven integration.

@johngrimes johngrimes merged commit 9f14742 into release/6.2.3 Jun 29, 2023
@johngrimes johngrimes deleted the 1443 branch June 29, 2023 06:46
@piotrszul piotrszul restored the 1443 branch June 30, 2023 02:47
@johngrimes johngrimes mentioned this pull request Jul 6, 2023
Closed
@johngrimes johngrimes deleted the 1443 branch July 7, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngrimes johngrimes johngrimes approved these changes

Assignees

@piotrszul piotrszul

Labels
None yet
Projects
Pathling
Status: Done
Milestone
v6.2.3
Development

Successfully merging this pull request may close these issues.

Databricks classpath conflicts
2 participants
@piotrszul @johngrimes